Summary: | Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength(). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||
Component: | CSS | Assignee: | Luke Macpherson <macpherson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, kling, macpherson, menard, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Luke Macpherson
2012-03-05 21:04:55 PST
Created attachment 130279 [details]
Patch
Comment on attachment 130279 [details]
Patch
I like this, but we should just early return now, since we don't need to fal through to the return l.
Do we know if this has a perf effect? (I kinda doubt it would).
I agree, but didn't change this function too much because I expect it to disappear entirely in a follow-up patch. Comment on attachment 130279 [details] Patch Clearing flags on attachment: 130279 Committed r109964: <http://trac.webkit.org/changeset/109964> All reviewed patches have been landed. Closing bug. |