Bug 80375

Summary: Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength().
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: CSSAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Luke Macpherson 2012-03-05 21:04:55 PST
Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength().
Comment 1 Luke Macpherson 2012-03-05 21:17:08 PST
Created attachment 130279 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-05 21:58:38 PST
Comment on attachment 130279 [details]
Patch

I like this, but we should just early return now, since we don't need to fal through to the return l.

Do we know if this has a perf effect?  (I kinda doubt it would).
Comment 3 Luke Macpherson 2012-03-06 14:09:00 PST
I agree, but didn't change this function too much because I expect it to disappear entirely in a follow-up patch.
Comment 4 WebKit Review Bot 2012-03-06 15:07:07 PST
Comment on attachment 130279 [details]
Patch

Clearing flags on attachment: 130279

Committed r109964: <http://trac.webkit.org/changeset/109964>
Comment 5 WebKit Review Bot 2012-03-06 15:07:11 PST
All reviewed patches have been landed.  Closing bug.