Bug 80368

Summary: pinch-to-zoom and double-tap flicker when using the new scrolling model
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Description Anders Carlsson 2012-03-05 19:45:40 PST 
pinch-to-zoom and double-tap flicker when using the new scrolling model
Comment 1 Anders Carlsson 2012-03-05 19:55:39 PST 
Created attachment 130271 [details]
Patch
Comment 2 Build Bot 2012-03-05 20:17:33 PST 
Comment on attachment 130271 [details]
Patch

Attachment 130271 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11834148
Comment 3 Anders Carlsson 2012-03-05 20:23:03 PST 
Created attachment 130275 [details]
Patch
Comment 4 Sam Weinig 2012-03-05 20:28:40 PST 
Comment on attachment 130275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130275&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:141
> +static void dispatchBackToMainThread(uint64_t webPageID, uint64_t callbackID)

Please consider renaming this to dispatchForceRepaintBackToMainThread or something like that.  Or just add a fixme about adding barriers/fences.
Comment 5 Anders Carlsson 2012-03-05 20:33:58 PST 
Committed r109843: <http://trac.webkit.org/changeset/109843>
Comment 6 mitz 2012-03-05 20:35:12 PST 
Comment on attachment 130275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130275&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:95
> +    IntRect scaledRect = rect;
> +    scaledRect.scale(m_scale);

IntRect::scale() truncates the origin and the size. I think this can cause problems.