Bug 80367

Summary: [BlackBerry]New feature: support about:cookie for internal build.
Product: WebKit Reporter: Jason Liu <jasonliuwebkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, jasonliuwebkit, joenotcharles, kpiascik, leo.yang, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jason Liu 2012-03-05 19:30:07 PST 
Need to show detail information of cookies.
Comment 1 Jason Liu 2012-03-05 22:06:44 PST 
Created attachment 130286 [details]
Patch
Comment 2 Joe Mason 2012-03-06 08:08:47 PST 
Comment on attachment 130286 [details]
Patch

There's no reason to declare cookieMap outside the for loop, since it's not used again.
You also shouldn't call getAllCookies as well as getAllChildCookies, since getAllChildCookies calls getAllCookies already, so this goes through the top-level map twice.
Comment 3 Jason Liu 2012-03-06 17:50:36 PST 
Created attachment 130499 [details]
Patch
Comment 4 Charles Wei 2012-03-07 19:38:10 PST 
Comment on attachment 130499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130499&action=review

> Source/WebCore/platform/blackberry/CookieManager.cpp:231
> +    result.append(String("<table style=\"word-wrap:break-word\" cellSpacing=\"0\" cellPadding=\"0\" border=\"1\"><tr><th width=\"54\">Domain</th><th width=\"32\">Path</th><th width=\"57\">Protocol</th><th width=\"40\">Name</th><th width=\"40\">Value</th><th width=\"46\">Secure</th><th width=\"64\">HttpOnly</th><th width=\"49\">Session</th></tr>"));

I don't link all the hardcoded numbers. Any other way to make it more intuitive ?
Comment 5 Jason Liu 2012-03-07 22:51:52 PST 
Created attachment 130774 [details]
Patch
Comment 6 Joe Mason 2012-03-08 08:25:10 PST 
LGTM
Comment 7 WebKit Review Bot 2012-03-08 11:01:58 PST 
Comment on attachment 130774 [details]
Patch

Clearing flags on attachment: 130774

Committed r110176: <http://trac.webkit.org/changeset/110176>
Comment 8 WebKit Review Bot 2012-03-08 11:02:02 PST 
All reviewed patches have been landed.  Closing bug.