Bug 80361

Summary: DFG BasicBlock should group the Phi nodes together and separate them from the other nodes
Product: WebKit Reporter: Yuqiang Xian <yuqiang.xian>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80415    
Attachments:
Description Flags
patch
fpizlo: review+
Performance result none

Yuqiang Xian
Reported 2012-03-05 17:45:03 PST
This would make it more efficient to remove the redundant Phi nodes or insert new Phi nodes for SSA, besides providing a cleaner BasicBlock structure.
Attachments
patch (12.46 KB, patch)
2012-03-05 18:00 PST, Yuqiang Xian 		fpizlo: review+
DetailsFormatted DiffDiff
Performance result (6.95 KB, text/plain)
2012-03-05 18:01 PST, Yuqiang Xian 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yuqiang Xian
Comment 1 2012-03-05 18:00:23 PST
Created attachment 130254 [details] patch
Yuqiang Xian
Comment 2 2012-03-05 18:01:13 PST
Created attachment 130255 [details] Performance result This is performance neutral. See attached.
Filip Pizlo
Comment 3 2012-03-06 19:14:38 PST
Comment on attachment 130254 [details] patch I like this a lot! R=me.
Yuqiang Xian
Comment 4 2012-03-06 20:57:02 PST
Landed as http://trac.webkit.org/changeset/110008
Note You need to log in before you can comment on or make changes to this bug.