Bug 80361

Summary: DFG BasicBlock should group the Phi nodes together and separate them from the other nodes
Product: WebKit Reporter: Yuqiang Xian <yuqiang.xian>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: barraclough, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80415    
Description Flags
fpizlo: review+
Performance result none

Description Yuqiang Xian 2012-03-05 17:45:03 PST
This would make it more efficient to remove the redundant Phi nodes or insert new Phi nodes for SSA, besides providing a cleaner BasicBlock structure.
Comment 1 Yuqiang Xian 2012-03-05 18:00:23 PST
Created attachment 130254 [details]
Comment 2 Yuqiang Xian 2012-03-05 18:01:13 PST
Created attachment 130255 [details]
Performance result

This is performance neutral. See attached.
Comment 3 Filip Pizlo 2012-03-06 19:14:38 PST
Comment on attachment 130254 [details]

I like this a lot!  R=me.
Comment 4 Yuqiang Xian 2012-03-06 20:57:02 PST
Landed as http://trac.webkit.org/changeset/110008