Bug 80352

Summary: WorkerContext shouldn't need to know about SQLDatabase
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, ojan, pnormand, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch none

Description Adam Barth 2012-03-05 16:56:08 PST
WorkerContext shouldn't need to know about SQLDatabase
Comment 1 Adam Barth 2012-03-05 16:59:02 PST
Created attachment 130235 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-05 17:03:03 PST
Comment on attachment 130235 [details]
Patch

OK.
Comment 3 Kentaro Hara 2012-03-05 17:04:34 PST
*** Bug 79473 has been marked as a duplicate of this bug. ***
Comment 4 WebKit Review Bot 2012-03-05 18:30:46 PST
Comment on attachment 130235 [details]
Patch

Clearing flags on attachment: 130235

Committed r109833: <http://trac.webkit.org/changeset/109833>
Comment 5 WebKit Review Bot 2012-03-05 18:30:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Philippe Normand 2012-03-05 23:39:18 PST
This change caused the fast/workers/storage tests to fail on GTK (at least).
Some tests show this message on the console: Can't find variable: openDatabaseSync
Comment 7 Adam Barth 2012-03-05 23:42:26 PST
I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?
Comment 8 Philippe Normand 2012-03-05 23:47:19 PST
(In reply to comment #7)
> I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?

Yes, http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release?numbuilds=50
Since r109833.
Comment 9 Philippe Normand 2012-03-06 00:03:27 PST
(In reply to comment #8)
> (In reply to comment #7)
> > I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?
> 
> Yes, http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release?numbuilds=50
> Since r109833.

A clean build is the solution. False alarm and sorry for the noise Adam!