Bug 80344

Summary: GCActivityCallback timer should vary with the length of the previous GC
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2012-03-05 16:29:15 PST
Currently our GC callback timer has a fixed length of 2 seconds. We should change it to be vary based on the length of the previous GC. This will allow us to control at a more fine-grained level exactly how much garbage collection should/is going on at a particular time.
Attachments
Patch (4.11 KB, patch)
2012-03-05 19:20 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-03-05 19:20:41 PST
Created attachment 130267 [details] Patch
Geoffrey Garen
Comment 2 2012-03-06 09:44:33 PST
Comment on attachment 130267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130267&action=review r=me > Source/JavaScriptCore/heap/Heap.cpp:332 > + , m_lastGCStartTime(0) > + , m_lastGCEndTime(0) These two should just be local variables inside collect().
Mark Hahnenberg
Comment 3 2012-03-06 13:32:38 PST
Committed r109956: <http://trac.webkit.org/changeset/109956>
Note You need to log in before you can comment on or make changes to this bug.