Bug 80344

Summary:

GCActivityCallback timer should vary with the length of the previous GC

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Mark Hahnenberg 2012-03-05 16:29:15 PST

Currently our GC callback timer has a fixed length of 2 seconds. We should change it to be vary based on the length of the previous GC. This will allow us to control at a more fine-grained level exactly how much garbage collection should/is going on at a particular time.

Comment 1 Mark Hahnenberg 2012-03-05 19:20:41 PST

Created attachment 130267 [details]
Patch

Comment 2 Geoffrey Garen 2012-03-06 09:44:33 PST

Comment on attachment 130267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130267&action=review

r=me

> Source/JavaScriptCore/heap/Heap.cpp:332
> +    , m_lastGCStartTime(0)
> +    , m_lastGCEndTime(0)

These two should just be local variables inside collect().

Comment 3 Mark Hahnenberg 2012-03-06 13:32:38 PST

Committed r109956: <http://trac.webkit.org/changeset/109956>