Bug 80335

Summary: putByIndex should throw in strict mode
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
fpizlo: review+
Part 2 - fixes pretty much everything. fpizlo: review+, buildbot: commit-queue-

Gavin Barraclough
Reported 2012-03-05 15:13:36 PST
We'll need to pass an additional parameter.
Attachments
patch (16.89 KB, patch)
2012-03-05 16:28 PST, Gavin Barraclough 		fpizlo: review+
DetailsFormatted DiffDiff
Part 2 - fixes pretty much everything. (72.90 KB, patch)
2012-03-05 22:45 PST, Gavin Barraclough 		fpizlo: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-03-05 16:28:28 PST
Created attachment 130226 [details] patch
Gavin Barraclough
Comment 2 2012-03-05 17:20:25 PST
Fixed for primitives in r109824.
Gavin Barraclough
Comment 3 2012-03-05 22:45:50 PST
Created attachment 130298 [details] Part 2 - fixes pretty much everything.
Gavin Barraclough
Comment 4 2012-03-05 23:24:00 PST
Part 2 landed in r109866, still need some fixing for shift/unshift.
Build Bot
Comment 5 2012-03-05 23:24:29 PST
Comment on attachment 130298 [details] Part 2 - fixes pretty much everything. Attachment 130298 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11837199
WebKit Review Bot
Comment 6 2012-03-05 23:26:07 PST
Comment on attachment 130298 [details] Part 2 - fixes pretty much everything. Attachment 130298 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11836194 New failing tests: fast/js/mozilla/strict/15.4.4.13.html fast/js/mozilla/strict/15.4.4.8.html fast/js/mozilla/strict/15.4.4.9.html fast/js/mozilla/strict/15.4.4.12.html
Kentaro Hara
Comment 7 2012-03-06 01:50:34 PST
(In reply to comment #6) > (From update of attachment 130298 [details]) > Attachment 130298 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11836194 > > New failing tests: > fast/js/mozilla/strict/15.4.4.13.html > fast/js/mozilla/strict/15.4.4.8.html > fast/js/mozilla/strict/15.4.4.9.html > fast/js/mozilla/strict/15.4.4.12.html It seems that this needs a V8 fix. I marked these tests as TEXT, and filed a bug in V8: http://code.google.com/p/v8/issues/detail?id=1992
Gavin Barraclough
Comment 8 2012-03-06 23:49:43 PST
Last piece of this was resolved as a part of bug#80467
Note You need to log in before you can comment on or make changes to this bug.