Bug 80308

Summary: Privately expose WKWebInspectorProxyObjCAdapter so Safari can add categories
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit2Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bweinstein, joepeck, sam, sullivan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Change
none
Proposed Change (round 2) sullivan: review+, timothy: commit-queue-

Description Timothy Hatcher 2012-03-05 11:44:07 PST 
The WKWebInspectorProxyObjCAdapter class impelments actions that are used by the Develop menu. This is hard to support and makes changing the Develop menu difficult. We shoudl expose WKWebInspectorProxyObjCAdapter so Safari can add the methods it needs.
Comment 1 Timothy Hatcher 2012-03-05 11:48:36 PST 
Created attachment 130172 [details]
Proposed Change
Comment 2 WebKit Review Bot 2012-03-05 11:52:04 PST 
Attachment 130172 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:26:  #ifndef header guard has wrong style, please use: WKInspectorPrivateMac_h  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Timothy Hatcher 2012-03-05 11:53:55 PST 
(In reply to comment #2)
> Attachment 130172 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
> Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:26:  #ifndef header guard has wrong style, please use: WKInspectorPrivateMac_h  [build/header_guard] [5]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Fixed locally.
Comment 4 Timothy Hatcher 2012-03-05 13:16:00 PST 
Created attachment 130192 [details]
Proposed Change (round 2)

With header guard fixed and inspectorRef as a @property.
Comment 5 WebKit Review Bot 2012-03-05 13:18:07 PST 
Attachment 130192 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Timothy Hatcher 2012-03-05 13:47:47 PST 
r109795