Bug 80306

Summary: Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Vsevolod Vlasov 2012-03-05 11:25:20 PST
Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Comment 1 Vsevolod Vlasov 2012-03-05 12:12:56 PST
Created attachment 130177 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-05 13:53:12 PST
Comment on attachment 130177 [details]
Patch

Attachment 130177 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11818174

New failing tests:
inspector/debugger/callstack-placards-discarded.html
Comment 3 Pavel Feldman 2012-03-05 22:04:10 PST
@podivilov: could you take a look?
Comment 4 Pavel Podivilov 2012-03-05 23:37:41 PST
Comment on attachment 130177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130177&action=review

Looks good!

> Source/WebCore/inspector/front-end/SourceFrame.js:216
> +        if (this._lineToReveal)

_lineToReveal is zero based, please fix the condition or delete unconditionally.
Comment 5 Vsevolod Vlasov 2012-03-06 04:05:33 PST
Created attachment 130350 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-03-06 04:29:15 PST
Committed r109903: <http://trac.webkit.org/changeset/109903>