Summary: | [Qt] Create EWS to build WebKit2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristóf Kosztyó <kkristof> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, ojan, ossy, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kristóf Kosztyó
2012-03-05 06:16:40 PST
Created attachment 130113 [details]
create wk2 ews
Comment on attachment 130113 [details] create wk2 ews View in context: https://bugs.webkit.org/attachment.cgi?id=130113&action=review LGTM, r=me with the following changes. > Tools/ChangeLog:3 > + [Qt] Create ews to build webkit2 ews -> EWS webkit2 -> WebKit2 > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:163 > +class QtWk2EWS(AbstractEarlyWarningSystem): QtWk2EWS -> QtWK2EWS > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:86 > + self._test_builder_ews(QtWk2EWS()) QtWk2EWS -> QtWK2EWS Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands? > Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands?
Nope. We'll need to do a re-deploy manually. Ping Eric or me when it lands and we can do that easily for you.
Created attachment 130320 [details]
fix the naming issues
Comment on attachment 130320 [details] fix the naming issues Clearing flags on attachment: 130320 Committed r109878: <http://trac.webkit.org/changeset/109878> All reviewed patches have been landed. Closing bug. |