Bug 80275

Summary:

Web Inspector: [Regression] Message bubbles are not removed from scripts panel source frames after console was cleared.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+
Screenshot (safari mac)	none
Screenshot (chromium linux)	none

Vsevolod Vlasov

Reported 2012-03-05 06:06:00 PST

Message bubbles are not removed from scripts panel source frames after console was cleared.

Attachments
Patch (2.46 KB, patch) 2012-03-05 06:08 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch (5.82 KB, patch) 2012-03-05 07:50 PST, Vsevolod Vlasov	pfeldman: review+	Details Formatted Diff Diff
Screenshot (safari mac) (40.07 KB, image/png) 2012-03-05 08:09 PST, Vsevolod Vlasov	no flags	Details
Screenshot (chromium linux) (70.62 KB, image/png) 2012-03-05 08:14 PST, Vsevolod Vlasov	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-03-05 06:08:23 PST

Created attachment 130108 [details] Patch

Pavel Feldman

Comment 2 2012-03-05 06:19:55 PST

Comment on attachment 130108 [details] Patch Could we have a test for this?

Vsevolod Vlasov

Comment 3 2012-03-05 07:50:50 PST

Created attachment 130133 [details] Patch

Vsevolod Vlasov

Comment 4 2012-03-05 08:09:50 PST

Created attachment 130140 [details] Screenshot (safari mac)

Vsevolod Vlasov

Comment 5 2012-03-05 08:14:45 PST

Created attachment 130142 [details] Screenshot (chromium linux)

Pavel Feldman

Comment 6 2012-03-05 21:41:59 PST

Re: screenshot: wrong bug?

Pavel Feldman

Comment 7 2012-03-05 21:49:55 PST

Comment on attachment 130133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130133&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:297 > + var sourceFrames = this._sourceFramesByUISourceCode.values(); This sounds more like compilation error rather than semantics error. Can we annotate the map interaction so that the compiler could catch such errors?

Vsevolod Vlasov

Comment 8 2012-03-06 01:33:37 PST

Committed r109882: <http://trac.webkit.org/changeset/109882>

Note You need to log in before you can comment on or make changes to this bug.