Bug 80268

Summary: Web Inspector: check for the number of parsed css properties.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Description Pavel Feldman 2012-03-05 05:20:00 PST
Not tests yet since can't repro.
Comment 1 Pavel Feldman 2012-03-05 05:21:19 PST
Created attachment 130098 [details]
Patch
Comment 2 Pavel Feldman 2012-03-05 06:35:45 PST
Created attachment 130114 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-03-05 06:52:02 PST
Comment on attachment 130114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130114&action=review

> LayoutTests/inspector/styles/set-property-boundaries.html:27
> +        for (var i = 0; i < infos.length; ++i)

Could you please use the first item only instead of iterating over all the items?

> LayoutTests/inspector/styles/set-property-boundaries.html:39
> +        for (var i = 0; i < styleSheet.rules.length; ++i)

ditto

> LayoutTests/inspector/styles/set-property-boundaries.html:51
> +        CSSAgent.setPropertyText(style.styleId, 10, "color:blue;", true, dumpErrorMessage);

Maybe const outOfBOundsRuleIndex = 42; ?
Comment 4 Pavel Feldman 2012-03-05 07:03:49 PST
> Could you please use the first item only instead of iterating over all the items?
> 

Done.

> > LayoutTests/inspector/styles/set-property-boundaries.html:39
> > +        for (var i = 0; i < styleSheet.rules.length; ++i)
> 
> ditto

Done.

> 
> > LayoutTests/inspector/styles/set-property-boundaries.html:51
> > +        CSSAgent.setPropertyText(style.styleId, 10, "color:blue;", true, dumpErrorMessage);
> 
> Maybe const outOfBOundsRuleIndex = 42; ?

Done.
Comment 5 Pavel Feldman 2012-03-05 07:08:18 PST
Committed r109741: <http://trac.webkit.org/changeset/109741>