Bug 80253

Summary:

REGRESSION(r109294): It broke the unittest of master.cfg

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lforschler, mrowe, ossy, wsiegrist

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	none

Csaba Osztrogonác

Reported 2012-03-05 01:26:42 PST

/usr/lib/python2.6/dist-packages/twisted/mail/smtp.py:10: DeprecationWarning: the MimeWriter module is deprecated; use the email package instead import MimeWriter, tempfile, rfc822 Traceback (most recent call last): File "./mastercfg_unittest.py", line 321, in <module> BuildBotConfigLoader().load_config('master.cfg') File "./mastercfg_unittest.py", line 48, in load_config execfile(master_cfg_path, globals(), globals()) File "master.cfg", line 870, in <module> loadBuilderConfig(c) File "master.cfg", line 807, in loadBuilderConfig passwords = json.load(open('passwords.json')) File "./mastercfg_unittest.py", line 26, in _mock_open return StringIO.StringIO(simplejson.dumps(self._create_mock_passwords_dict())) NameError: global name 'simplejson' is not defined Patch is coming soon.

Attachments
proposed fix (2.70 KB, patch) 2012-03-05 01:32 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2012-03-05 01:32:45 PST

Created attachment 130079 [details] proposed fix

Tor Arne Vestbø

Comment 2 2012-03-06 04:24:33 PST

Comment on attachment 130079 [details] proposed fix lgtm based on http://trac.webkit.org/changeset/109294/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

Csaba Osztrogonác

Comment 3 2012-03-06 04:25:36 PST

Landed in http://trac.webkit.org/changeset/109902

Note You need to log in before you can comment on or make changes to this bug.