Bug 80243

Summary: Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Shinya Kawanaka 2012-03-04 23:43:01 PST 
Since <shadow> will have to do almost the same thing for <content>, it's natural that InsertionPoint::attach() has the same code as HTMLContentElemetn::attach().
Comment 1 Shinya Kawanaka 2012-03-05 00:08:15 PST 
Created attachment 130063 [details]
Patch
Comment 2 Hajime Morrita 2012-03-05 00:16:45 PST 
Comment on attachment 130063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130063&action=review

> Source/WebCore/ChangeLog:9
> +        elements. So it is natural that InsertionPoint::attach() has such code.

Doesn't need "so". Could be single sentence?
Comment 3 Shinya Kawanaka 2012-03-05 00:20:13 PST 
Created attachment 130064 [details]
Patch for landing
Comment 4 Shinya Kawanaka 2012-03-05 00:22:56 PST 
Committed r109718: <http://trac.webkit.org/changeset/109718>