Summary: | [Forms] The "legend" element should not be a form-associated element. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||
Component: | Forms | Assignee: | yosin | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 80381 | ||||||||||
Attachments: |
|
Description
yosin
2012-03-04 21:29:51 PST
Created attachment 130299 [details]
Patch 1
This bug is part of HTMLFormControlElement re-factoring bug https://bugs.webkit.org/show_bug.cgi?id=80381 Comment on attachment 130299 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=130299&action=review The code change looks ok. > Source/WebCore/ChangeLog:9 > + This patch changes base class of HTMLLegendElement to HTMLElement from > + HTMLFormControlElement. You should mention a reason why we should change this. Created attachment 130500 [details]
Patch 2
Comment on attachment 130500 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=130500&action=review > Source/WebCore/ChangeLog:10 > + This patch changes base class of HTMLLegendElement to HTMLElement from > + HTMLFormControlElement to match C++ class hierarchy to the specification > + and to be out from FormAssociatedElement class tree. So, why we should follow the class hierarchy in the specification? Why HTMLLegendElement should not inherit from FormAssociatedElement? You should say the benefit of the change. Created attachment 130524 [details]
Patch 3
Comment on attachment 130524 [details]
Patch 3
ok
Comment on attachment 130524 [details] Patch 3 Clearing flags on attachment: 130524 Committed r110029: <http://trac.webkit.org/changeset/110029> All reviewed patches have been landed. Closing bug. |