Bug 80232

Summary: Add account to committer list
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: Tools / TestsAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Trivial CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to add charles.wei@torchmobile.com.cn to the committer list. none

Charles Wei
Reported 2012-03-04 19:24:57 PST
Need to add account charles.wei@torchmobile.com.cn to the committer list who was just granted the commit access. I submit a patch for this because we have direct SVN access problem here in China and have to have a patch for a bug to get this change landed. Will have the SVN access figured out later and won't do this any more.
Attachments
Patch to add charles.wei@torchmobile.com.cn to the committer list. (1.88 KB, patch)
2012-03-04 19:39 PST, Charles Wei 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-03-04 19:39:00 PST
Created attachment 130046 [details] Patch to add charles.wei@torchmobile.com.cn to the committer list. patch
Charles Wei
Comment 2 2012-03-04 19:42:44 PST
Comment on attachment 130046 [details] Patch to add charles.wei@torchmobile.com.cn to the committer list. Try to commit it by myself.
WebKit Review Bot
Comment 3 2012-03-04 19:42:58 PST
Comment on attachment 130046 [details] Patch to add charles.wei@torchmobile.com.cn to the committer list. Rejecting attachment 130046 [details] from commit-queue. charles.wei@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 4 2012-03-04 20:02:29 PST
Comment on attachment 130046 [details] Patch to add charles.wei@torchmobile.com.cn to the committer list. Clearing flags on attachment: 130046 Committed r109701: <http://trac.webkit.org/changeset/109701>
WebKit Review Bot
Comment 5 2012-03-04 20:02:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.