Bug 80232 - Add account to committer list
Summary: Add account to committer list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-04 19:24 PST by Charles Wei
Modified: 2012-03-04 20:02 PST (History)
3 users (show)

See Also:


Attachments
Patch to add charles.wei@torchmobile.com.cn to the committer list. (1.88 KB, patch)
2012-03-04 19:39 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-04 19:24:57 PST
Need to add account charles.wei@torchmobile.com.cn to the committer list who was just granted the commit access.

I submit a patch for this because we have direct SVN access problem here in China and have to have a patch for a bug to get this change landed. Will have the SVN access figured out later and won't do this any more.
Comment 1 Charles Wei 2012-03-04 19:39:00 PST
Created attachment 130046 [details]
Patch to add charles.wei@torchmobile.com.cn to the committer list.

patch
Comment 2 Charles Wei 2012-03-04 19:42:44 PST
Comment on attachment 130046 [details]
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Try to commit it by myself.
Comment 3 WebKit Review Bot 2012-03-04 19:42:58 PST
Comment on attachment 130046 [details]
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Rejecting attachment 130046 [details] from commit-queue.

charles.wei@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2012-03-04 20:02:29 PST
Comment on attachment 130046 [details]
Patch to add charles.wei@torchmobile.com.cn to the committer list.

Clearing flags on attachment: 130046

Committed r109701: <http://trac.webkit.org/changeset/109701>
Comment 5 WebKit Review Bot 2012-03-04 20:02:33 PST
All reviewed patches have been landed.  Closing bug.