Bug 80211

Summary: [EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, lucas.de.marchi, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 62961    
Bug Blocks: 79766    
Attachments:
Description Flags
Patch
none
proposed patch
noam: review-, webkit.review.bot: commit-queue-
modified patch none

Description Hyowon Kim 2012-03-03 01:51:55 PST 
The last patch for GC3DPrivate implementation, which contains initialize() and the destructor function using Evas_GL APIs.
Comment 1 Hyowon Kim 2012-03-03 01:55:20 PST 
Created attachment 129998 [details]
Patch
Comment 2 Hyowon Kim 2012-03-03 02:04:08 PST 
Created attachment 129999 [details]
proposed patch
Comment 3 WebKit Review Bot 2012-03-03 04:00:16 PST 
Comment on attachment 129999 [details]
proposed patch

Attachment 129999 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11799322

New failing tests:
editing/selection/select-line-break-with-opposite-directionality.html
Comment 4 Noam Rosenthal 2012-03-03 07:46:56 PST 
Comment on attachment 129999 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129999&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:58
> +    if (m_evasGL) {

Style: early-return here.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:87
> +    m_context = evas_gl_context_create(m_evasGL, 0);

What does 0 stand for? comment.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:102
> +    int x = 0, y = 0, width = 1, height = 1;

separate lines.
Comment 5 Hyowon Kim 2012-03-04 00:59:50 PST 
Created attachment 130018 [details]
modified patch

I've added some codes for context sharing between AC and WebGL.
Comment 6 WebKit Review Bot 2012-03-04 19:15:32 PST 
Comment on attachment 130018 [details]
modified patch

Clearing flags on attachment: 130018

Committed r109696: <http://trac.webkit.org/changeset/109696>
Comment 7 WebKit Review Bot 2012-03-04 19:15:37 PST 
All reviewed patches have been landed.  Closing bug.