Summary: | Replace uses of x(), y() and width(), height() pairs with locationOffset and size() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, jamesr, jchaffraix, leviw, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Emil A Eklund
2012-03-02 15:11:04 PST
Created attachment 129970 [details]
Patch
Comment on attachment 129970 [details]
Patch
Nit: In HTMLCanvasElement, this line could welcome the same change: FloatRect r = mapRect(rect, FloatRect(0, 0, size().width(), size().height()), destRect);
Also there are other places where we could use the same pattern (like IntRect(0, 0, someComputedHeight, someComputedWidth) in the rendering code) so it seems as if the title is misleading IMHO.
Thanks! I'll make the suggested changes to HTMLCanvasElement and have renamed the bug to make it clear what I am changing. (In reply to comment #3) > Thanks! I'll make the suggested changes to HTMLCanvasElement and have renamed the bug to make it clear what I am changing. It makes it a little bit clearer but what I had in mind was not to use 'remaining' as there are some remaining use after your change (look at RenderScrollbar.cpp for example). Good point. Grep failed to find some of the computed value ones. I'll take care of the ones in RenderScrollbar and have updated the summary as suggested. Created attachment 130174 [details]
Patch for landing
Comment on attachment 130174 [details]
Patch for landing
These changes are so fantastic. Thank you.
Comment on attachment 130174 [details] Patch for landing Clearing flags on attachment: 130174 Committed r109805: <http://trac.webkit.org/changeset/109805> All reviewed patches have been landed. Closing bug. |