Bug 80192

Summary: [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: WebKit Misc.Assignee: Takashi Toyoshima <toyoshim>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Takashi Toyoshima 2012-03-02 14:02:08 PST 
WebKit/chromium/src/WebSocketImpl.h doesn't use OVERRIDE macro.
Also binaryType() lack 'virtual' declaration.
Comment 1 Takashi Toyoshima 2012-03-02 14:07:30 PST 
Created attachment 129956 [details]
Patch
Comment 2 Kent Tamura 2012-03-02 17:23:03 PST 
Comment on attachment 129956 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-03-02 18:43:00 PST 
Comment on attachment 129956 [details]
Patch

Rejecting attachment 129956 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11803226
Comment 4 Takashi Toyoshima 2012-03-05 09:27:38 PST 
Comment on attachment 129956 [details]
Patch

try cq+ again
Comment 5 WebKit Review Bot 2012-03-05 10:58:00 PST 
Comment on attachment 129956 [details]
Patch

Clearing flags on attachment: 129956

Committed r109771: <http://trac.webkit.org/changeset/109771>
Comment 6 WebKit Review Bot 2012-03-05 10:58:06 PST 
All reviewed patches have been landed.  Closing bug.