Bug 80192 – [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Takashi Toyoshima]

WebKit/chromium/src/WebSocketImpl.h doesn't use OVERRIDE macro.
Also binaryType() lack 'virtual' declaration.

[Takashi Toyoshima]

Created attachment 129956 [details]
Patch

[Kent Tamura]

Comment on attachment 129956 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 129956 [details]
Patch

Rejecting attachment 129956 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11803226

[Takashi Toyoshima]

Comment on attachment 129956 [details]
Patch

try cq+ again

[WebKit Review Bot]

Comment on attachment 129956 [details]
Patch

Clearing flags on attachment: 129956

Committed r109771: <http://trac.webkit.org/changeset/109771>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.