Bug 80188

Summary: Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75069    
Attachments:
Description Flags
Patch rniwa: review+

Caio Marcelo de Oliveira Filho
Reported 2012-03-02 13:37:36 PST
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
Attachments
Patch (5.53 KB, patch)
2012-03-02 13:41 PST, Caio Marcelo de Oliveira Filho 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-03-02 13:41:09 PST
Created attachment 129951 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-02 14:13:00 PST
Comment on attachment 129951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129951&action=review > Source/WebCore/dom/NamedNodeMap.cpp:108 > + Attr* attr = static_cast<Attr*>(node); > + return m_element->setAttributeNode(attr, ec); Do we really need a local variable?
Caio Marcelo de Oliveira Filho
Comment 3 2012-03-02 14:59:59 PST
Committed r109619: <http://trac.webkit.org/changeset/109619>
Note You need to log in before you can comment on or make changes to this bug.