| Summary: | allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, haraken, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 79327 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2012-03-02 11:56:25 PST
Created attachment 129935 [details]
Patch
Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11799076 Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11796111 Comment on attachment 129935 [details] Patch Attachment 129935 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11803071 Created attachment 129948 [details]
Patch
Comment on attachment 129948 [details]
Patch
OK. I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables?
> OK. I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables?
Yes. The Suplement object is owned by the Suplementable object.
Comment on attachment 129948 [details] Patch Rejecting attachment 129948 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11801210 Comment on attachment 129948 [details] Patch Clearing flags on attachment: 129948 Committed r109716: <http://trac.webkit.org/changeset/109716> All reviewed patches have been landed. Closing bug. |