Summary: | Revert borders to integers for subpixel layout | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, eric, leviw, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60318 | ||||||
Attachments: |
|
Description
Emil A Eklund
2012-03-02 11:33:14 PST
Created attachment 129931 [details]
Patch
Comment on attachment 129931 [details]
Patch
hmm... So even table borders are not sub-pixel precise? I know individual cell-layout for tables is done with integers... but I'm surprised that borders around said table would be?
(In reply to comment #2) > (From update of attachment 129931 [details]) > hmm... So even table borders are not sub-pixel precise? I know individual cell-layout for tables is done with integers... but I'm surprised that borders around said table would be? Borders are aligned to device pixels to ensure that a box with border a style such as "0.3ex solid black" has all four borders rendered with the same width regardless of the offset. If we did this with subpixel precision the bottom/right border might be pained width a different width. Comment on attachment 129931 [details] Patch Attachment 129931 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11799129 New failing tests: editing/selection/select-line-break-with-opposite-directionality.html Comment on attachment 129931 [details] Patch Clearing flags on attachment: 129931 Committed r109642: <http://trac.webkit.org/changeset/109642> All reviewed patches have been landed. Closing bug. |