Summary: | Create a method in Element to compare attributes with other Element | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
Component: | New Bugs | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, kling, koivisto, pnormand, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 75069 | ||||||
Attachments: |
|
Description
Caio Marcelo de Oliveira Filho
2012-03-02 10:12:10 PST
Created attachment 129918 [details]
Patch
Comment on attachment 129918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129918&action=review > Source/WebCore/dom/Node.cpp:1775 > + if (isElementNode() && !toElement(this)->hasEquivalentAttributes(toElement(other))) Maybe we should an inline helper that takes Node* and returns false when its' not an element? That'll avoid having to cast nodes. > Source/WebCore/editing/htmlediting.cpp:1161 > + if (!firstElement->tagQName().matches(secondElement->tagQName())) Can't we do firstElement->hasTagQName(secondElement->tagQName()) ? Maybe this is slower? This is a very nice refactoring! Committed r109585: <http://trac.webkit.org/changeset/109585> (In reply to comment #4) > Committed r109585: <http://trac.webkit.org/changeset/109585> Broke the GTK build :( (In reply to comment #5) > (In reply to comment #4) > > Committed r109585: <http://trac.webkit.org/changeset/109585> > > Broke the GTK build :( Sorry it seems to be a false alarm, the 64-bit Release bot looks hosed, let's try a full clean build. |