Bug 80144

Summary:

Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore Misc.

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, ojan, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79327

Attachments:

Description	Flags
Patch	none
patch for landing	none

Kentaro Hara

Reported 2012-03-02 04:12:53 PST

Based on the discussion on webkit-dev@ (http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results), we should revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.

Attachments
Patch (9.26 KB, patch) 2012-03-02 04:22 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
patch for landing (9.32 KB, patch) 2012-03-04 16:49 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-03-02 04:22:03 PST

Created attachment 129875 [details] Patch

WebKit Review Bot

Comment 2 2012-03-02 15:41:35 PST

Comment on attachment 129875 [details] Patch Rejecting attachment 129875 [details] from commit-queue. New failing tests: editing/selection/select-line-break-with-opposite-directionality.html Full output: http://queues.webkit.org/results/11795192

WebKit Review Bot

Comment 3 2012-03-02 16:01:02 PST

Comment on attachment 129875 [details] Patch Rejecting attachment 129875 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: oj Hunk #1 FAILED at 10803. Hunk #2 succeeded at 14591 (offset 4 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/html/canvas/DOMWindowWebGL.idl rm 'Source/WebCore/html/canvas/DOMWindowWebGL.idl' patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11801166

Kentaro Hara

Comment 4 2012-03-04 16:49:54 PST

Created attachment 130033 [details] patch for landing

WebKit Review Bot

Comment 5 2012-03-04 18:24:39 PST

Comment on attachment 130033 [details] patch for landing Clearing flags on attachment: 130033 Committed r109691: <http://trac.webkit.org/changeset/109691>

Note You need to log in before you can comment on or make changes to this bug.