Summary: | [EFL][DRT] Implement LayoutTestController's methods related with editing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Grzegorz Czajkowski <g.czajkowski> | ||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Grzegorz Czajkowski
2012-03-02 02:52:22 PST
Created attachment 130122 [details]
proposed patch
Comment on attachment 130122 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=130122&action=review I'd rather avoid doing what the Qt port does/used to do and make WebCoreSupport aware of DRT; the current code was written with that in mind, and I think we can keep doing so. Isn't it possible to make DRTSupportEefl::setSelectTrailingWhitespaceEnabled set some flag in EditClient itself or in ewk_view? > LayoutTests/platform/efl/Skipped:67 > +editing/selection/doubleclick-inline-first-last-contenteditable.html Please keep the list alphabetically sorted. Created attachment 130563 [details]
updated patch according to Kubo's review
(In reply to comment #2) > (From update of attachment 130122 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130122&action=review > > I'd rather avoid doing what the Qt port does/used to do and make WebCoreSupport aware of DRT; the current code was written with that in mind, and I think we can keep doing so. Isn't it possible to make DRTSupportEefl::setSelectTrailingWhitespaceEnabled set some flag in EditClient itself or in ewk_view? Ok, I added flag to EditorClinetEfl to set/get selectTrailingWhitespaceEnabled (similar to smartInsertDeleteEnabled). > > > LayoutTests/platform/efl/Skipped:67 > > +editing/selection/doubleclick-inline-first-last-contenteditable.html > > Please keep the list alphabetically sorted. Done. Created attachment 130568 [details]
rebased patch to HEAD
Comment on attachment 130568 [details]
rebased patch to HEAD
Looks fine to me.
Comment on attachment 130568 [details] rebased patch to HEAD View in context: https://bugs.webkit.org/attachment.cgi?id=130568&action=review > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:235 > + m_smartInsertDeleteEnabled = enabled; You also need to set m_selectTrailingWhitespaceEnabled false if enabled was true here. > Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:245 > + m_selectTrailingWhitespaceEnabled = enabled; You need to set m_smartInsertDeleteEnabled false if enabled was true here. Created attachment 133254 [details] updated patch Added Ryosuke's suggestions. Removed hasSpellingMarker implementation from current patch - hasSpellingMarker should be used through Internals interface https://bugs.webkit.org/show_bug.cgi?id=81300. Patch for landing :) Comment on attachment 133254 [details] updated patch Clearing flags on attachment: 133254 Committed r111835: <http://trac.webkit.org/changeset/111835> All reviewed patches have been landed. Closing bug. |