Summary: | HTMLTrackElement.idl doesn't have default attribute. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, annacc, arun.patole, eric.carlson, haraken, ojan, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
yosin
2012-03-01 23:55:33 PST
(In reply to comment #0) > See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element I could see it in HTMLTrackElement.idl: "attribute [Reflect=default] boolean isDefault;" http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTrackElement.idl > I could see it in HTMLTrackElement.idl:
> "attribute [Reflect=default] boolean isDefault;"
In JS, it will be track.isDefault instead of track.default.
We would like to have
attribute [Reflect] boolean default;
(In reply to comment #2) > > I could see it in HTMLTrackElement.idl: > > "attribute [Reflect=default] boolean isDefault;" > > In JS, it will be track.isDefault instead of track.default. > We would like to have > attribute [Reflect] boolean default; ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc. (In reply to comment #3) > (In reply to comment #2) > > > I could see it in HTMLTrackElement.idl: > > > "attribute [Reflect=default] boolean isDefault;" > > > > In JS, it will be track.isDefault instead of track.default. > > We would like to have > > attribute [Reflect] boolean default; > ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc. I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug. Created attachment 130554 [details]
proposed patch
Comment on attachment 130554 [details] proposed patch The change looks sane. (In reply to comment #4) > I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug. It seems that 'isDefault' was introduced in the initial patch of HTMLTrackElement.idl (https://bugs.webkit.org/attachment.cgi?id=89094&action=review). Comment on attachment 130554 [details] proposed patch Clearing flags on attachment: 130554 Committed r110052: <http://trac.webkit.org/changeset/110052> All reviewed patches have been landed. Closing bug. |