Summary: | [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||
Component: | Platform | Assignee: | yosin | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, fishd, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 79764 | ||||||
Attachments: |
|
Description
yosin
2012-03-01 20:16:53 PST
Created attachment 129804 [details]
Patch 1
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Comment on attachment 129804 [details]
Patch 1
Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that.
(In reply to comment #3) > (From update of attachment 129804 [details]) > Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that. HTMLOptionElement shouldn't inherit from HTMLFormControlElement. The current implementation of HTMLOptionElement wastes memory and time, and we have an actual performance bug reported by a user. yosin is going to change it. See Bug 79764. Comment on attachment 129804 [details]
Patch 1
OK!
Comment on attachment 129804 [details] Patch 1 Clearing flags on attachment: 129804 Committed r109827: <http://trac.webkit.org/changeset/109827> All reviewed patches have been landed. Closing bug. |