Bug 80089

Summary: [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79764    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-03-01 20:16:53 PST
According to specification, WebOptionElement isn't form associated control(FormControlElement is derived from FormAssociateElement) . To avoid having extra functionality and removing extra dependency, WebOptionElement should derive from WebElement rather than WebFormControlElement.
Attachments
Patch 1 (3.12 KB, patch)
2012-03-01 21:13 PST, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-03-01 21:13:30 PST
Created attachment 129804 [details] Patch 1
WebKit Review Bot
Comment 2 2012-03-01 21:18:00 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2012-03-02 15:40:12 PST
Comment on attachment 129804 [details] Patch 1 Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that.
Kent Tamura
Comment 4 2012-03-02 17:20:13 PST
(In reply to comment #3) > (From update of attachment 129804 [details]) > Why? HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that. HTMLOptionElement shouldn't inherit from HTMLFormControlElement. The current implementation of HTMLOptionElement wastes memory and time, and we have an actual performance bug reported by a user. yosin is going to change it. See Bug 79764.
Darin Fisher (:fishd, Google)
Comment 5 2012-03-05 17:10:23 PST
Comment on attachment 129804 [details] Patch 1 OK!
WebKit Review Bot
Comment 6 2012-03-05 17:39:12 PST
Comment on attachment 129804 [details] Patch 1 Clearing flags on attachment: 129804 Committed r109827: <http://trac.webkit.org/changeset/109827>
WebKit Review Bot
Comment 7 2012-03-05 17:39:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.