Bug 80076
| Summary: | Make V8CSSStyleDeclaration work directly with CSS Property ID | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | abarth, arv, haraken |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
http://trac.webkit.org/changeset/108257 improved DOM/Accessors.html's score by 45%. We should do the same optimization.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Erik Arvidsson
We already do this optimization.
cssPropertyInfo caches the lookup from the string to the property ID and whether the property has a pos or pixel prefix.
Kentaro Hara
(In reply to comment #1)
> We already do this optimization.
>
> cssPropertyInfo caches the lookup from the string to the property ID and whether the property has a pos or pixel prefix.
Thanks, arv. I confirmed it.
Also I confirmed that the reason why V8's DOM/Accessors.html is still much slower than JSC's DOM/Accessors.html is due to the slowness of V8 DOM bindings. (I am investigating the issue in https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AlobCOyvTnPKdDhqQlpybE11Ui1fbTRHNFd2ZHh4bEE&ndplr=1#gid=0)
Kentaro Hara
Although I played around some optimization, I couldn't optimize V8CSSStyleDeclaration as far as I modify V8CSSStyleDeclarationCustom.cpp.
As a side effect of the investigation, I might be able to optimize JSCSSStyleDeclarationCustom.cpp:-) bug 80250