Bug 80067 – Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Klein]

The following layout test is flaky on Chromium debug (all platforms):

media/track/track-cues-pause-on-exit.html

See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-cues-pause-on-exit.html

It seems to have been failing flakily since it was added 9 days ago.

[Victor Carbune]

Created attachment 129895 [details]
Fixed flaky test

This test seems to be flaky because of the to small intervals between cues exit events, which groups them in multiple missed cues at once. The video is paused synchronously while exit events are dispatched asynchronously, which sometimes leads to an inconsistency when the value of video.paused is read

[Eric Carlson]

Comment on attachment 129895 [details]
Fixed flaky test

View in context: https://bugs.webkit.org/attachment.cgi?id=129895&action=review

> LayoutTests/media/track/track-cues-pause-on-exit.html:50
> +                if (currentCueNumber == 3) {
> +                    endTest();
> +                }

Nit: braces aren't necessary because there is only one line.

[Victor Carbune]

Created attachment 130711 [details]
Corrected coding style issues

[WebKit Review Bot]

Comment on attachment 130711 [details]
Corrected coding style issues

Clearing flags on attachment: 130711

Committed r110168: <http://trac.webkit.org/changeset/110168>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ami Fischman]

Victor: did you mean to also remove this test from test_expectations.txt?  It doesn't seem to be failing anymore.

[Eric Carlson]

It still fails for me, the 'exit' event fires twice for cue ID 0 and ID 1:

@@ -16,12 +16,12 @@
 EXPECTED (video.paused == 'false') OK
 
 EVENT(exit)
-EXPECTED (currentCue.id == '2') OK
+EXPECTED (currentCue.id == '2'), OBSERVED '0' FAIL
 EXPECTED (video.paused == 'true') OK
 RUN(video.play())
 
 EVENT(exit)
-EXPECTED (currentCue.id == '3') OK
+EXPECTED (currentCue.id == '3'), OBSERVED '1' FAIL
 EXPECTED (video.paused == 'false') OK
 END OF TEST

[Eric Carlson]

I wonder if what I am seeing is related to bug #77862?

[Victor Carbune]

Created attachment 138351 [details]
Patch using waitForEvent

Slightly different approach, waiting for video paused events and after for the queued cue exit events

[Eric Carlson]

Comment on attachment 138351 [details]
Patch using waitForEvent

Oops, I missed this patch somehow - sorry for the delay in reviewing it!

[WebKit Review Bot]

Comment on attachment 138351 [details]
Patch using waitForEvent

Clearing flags on attachment: 138351

Committed r116148: <http://trac.webkit.org/changeset/116148>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.