Summary: | Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||||||
Component: | Tools / Tests | Assignee: | Victor Carbune <vcarbune> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, fischman, vcarbune, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adam Klein
2012-03-01 16:29:39 PST
Created attachment 129895 [details]
Fixed flaky test
This test seems to be flaky because of the to small intervals between cues exit events, which groups them in multiple missed cues at once. The video is paused synchronously while exit events are dispatched asynchronously, which sometimes leads to an inconsistency when the value of video.paused is read
Comment on attachment 129895 [details] Fixed flaky test View in context: https://bugs.webkit.org/attachment.cgi?id=129895&action=review > LayoutTests/media/track/track-cues-pause-on-exit.html:50 > + if (currentCueNumber == 3) { > + endTest(); > + } Nit: braces aren't necessary because there is only one line. Created attachment 130711 [details]
Corrected coding style issues
Comment on attachment 130711 [details] Corrected coding style issues Clearing flags on attachment: 130711 Committed r110168: <http://trac.webkit.org/changeset/110168> All reviewed patches have been landed. Closing bug. Victor: did you mean to also remove this test from test_expectations.txt? It doesn't seem to be failing anymore. It still fails for me, the 'exit' event fires twice for cue ID 0 and ID 1: @@ -16,12 +16,12 @@ EXPECTED (video.paused == 'false') OK EVENT(exit) -EXPECTED (currentCue.id == '2') OK +EXPECTED (currentCue.id == '2'), OBSERVED '0' FAIL EXPECTED (video.paused == 'true') OK RUN(video.play()) EVENT(exit) -EXPECTED (currentCue.id == '3') OK +EXPECTED (currentCue.id == '3'), OBSERVED '1' FAIL EXPECTED (video.paused == 'false') OK END OF TEST I wonder if what I am seeing is related to bug #77862? Created attachment 138351 [details]
Patch using waitForEvent
Slightly different approach, waiting for video paused events and after for the queued cue exit events
Comment on attachment 138351 [details]
Patch using waitForEvent
Oops, I missed this patch somehow - sorry for the delay in reviewing it!
Comment on attachment 138351 [details] Patch using waitForEvent Clearing flags on attachment: 138351 Committed r116148: <http://trac.webkit.org/changeset/116148> All reviewed patches have been landed. Closing bug. |