Bug 80033

Summary: WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
Product: WebKit Reporter: Kalev Lember <kalevlember>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch none

Kalev Lember
Reported 2012-03-01 09:37:24 PST
WebKitTestRunner/TestInvocation.cpp uses getcwd(), but only includes the unistd.h header for Mac. This worked fine in the past because gcc < 4.7 included unistd.h from standard C++ library headers. However, this is no longer the case with gcc 4.7 and we need to explicitly include unistd.h.
Attachments
Patch (1.65 KB, patch)
2012-03-01 09:40 PST, Kalev Lember 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kalev Lember
Comment 1 2012-03-01 09:40:54 PST
Created attachment 129717 [details] Patch
WebKit Review Bot
Comment 2 2012-03-01 22:26:24 PST
Comment on attachment 129717 [details] Patch Clearing flags on attachment: 129717 Committed r109509: <http://trac.webkit.org/changeset/109509>
WebKit Review Bot
Comment 3 2012-03-01 22:26:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.