Bug 80031

Summary:

[GTK] Parts of WebKitTestRunner are getting built even if WK2 is disabled

Product:

WebKit

Reporter:

Kalev Lember <kalevlember>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Kalev Lember 2012-03-01 09:23:41 PST

The libTestRunnerInjectedBundle.la convencience library is missing a guard to avoid building it when WebKit2GTK+ is disabled. This isn't much of a problem on Linux, but breaks build for Windows where WK2 doesn't (yet) build properly.

Comment 1 Kalev Lember 2012-03-01 09:26:17 PST

Created attachment 129714 [details]
Patch

Comment 2 WebKit Review Bot 2012-03-01 12:38:07 PST

Comment on attachment 129714 [details]
Patch

Clearing flags on attachment: 129714

Committed r109396: <http://trac.webkit.org/changeset/109396>

Comment 3 WebKit Review Bot 2012-03-01 12:38:11 PST

All reviewed patches have been landed.  Closing bug.