Bug 80026

Summary:

[EFL] Prefix run-launcher with run-with-jhbuild

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

Tools / Tests

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pnormand, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Bug Depends on:

79673

Bug Blocks:

79480

Attachments:

Description	Flags
Run launcher under jhbuild, v1	none
Run launcher under jhbuild, v2	pnormand: review+
Run launcher under jhbuild, v3	none

Description Dominik Röttsches (drott) 2012-03-01 07:28:03 PST

In order for the launcher to use the jhbuild-provided EFL libaries, let's prefix it with run-with-jhbuild as well.

Comment 1 Dominik Röttsches (drott) 2012-03-15 08:25:48 PDT

Created attachment 132056 [details]
Run launcher under jhbuild, v1

Comment 2 Dominik Röttsches (drott) 2012-03-16 07:37:50 PDT

Created attachment 132282 [details]
Run launcher under jhbuild, v2

catfile not required, patch simplified.

Comment 3 Philippe Normand 2012-03-19 02:27:00 PDT

Comment on attachment 132282 [details]
Run launcher under jhbuild, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=132282&action=review

> Tools/Scripts/run-launcher:77
> +        my $jhbuildWrapper = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild");
> +        $launcherPath = $jhbuildWrapper;

Maybe this can be one line?

$launcherPath = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild");

Comment 4 Dominik Röttsches (drott) 2012-03-19 02:38:14 PDT

Created attachment 132561 [details]
Run launcher under jhbuild, v3

In one line, changelog rebased.

Comment 5 WebKit Review Bot 2012-03-19 03:47:46 PDT

Comment on attachment 132561 [details]
Run launcher under jhbuild, v3

Clearing flags on attachment: 132561

Committed r111172: <http://trac.webkit.org/changeset/111172>

Comment 6 WebKit Review Bot 2012-03-19 03:47:51 PDT

All reviewed patches have been landed.  Closing bug.