Bug 80002

Summary: Fallback elements in Non-youngest shadow tree should not be rendered.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
morrita: review+
Patch
none
Patch for landing none

Description Shinya Kawanaka 2012-02-29 21:01:10 PST 
Why does it take 'fallback' argument and it creates a fallback text if 'fallback' is not provided?
It's very confusing...
Comment 1 Shinya Kawanaka 2012-02-29 21:26:18 PST 
Created attachment 129628 [details]
Patch
Comment 2 Shinya Kawanaka 2012-02-29 21:57:34 PST 
Committed r109309: <http://trac.webkit.org/changeset/109309>
Comment 3 Shinya Kawanaka 2012-02-29 23:11:10 PST 
Reverted r109309 for reason:

broke

Committed r109315: <http://trac.webkit.org/changeset/109315>
Comment 4 Shinya Kawanaka 2012-02-29 23:33:31 PST 
I found a bug in NodeRenderingContext. Fallback elements in non-youngest shadow tree was rendered... It should not be rendered.
Comment 5 Shinya Kawanaka 2012-02-29 23:34:04 PST 
Let's reuse this bug to fix it.
Comment 6 Shinya Kawanaka 2012-02-29 23:46:06 PST 
Created attachment 129644 [details]
Patch
Comment 7 Hajime Morrita 2012-02-29 23:50:24 PST 
Comment on attachment 129644 [details]
Patch

Looks OK. Please nominate the test name in ChangeLog.
Comment 8 Shinya Kawanaka 2012-02-29 23:53:49 PST 
Created attachment 129646 [details]
Patch for landing
Comment 9 Shinya Kawanaka 2012-02-29 23:58:47 PST 
Committed r109321: <http://trac.webkit.org/changeset/109321>