Bug 79965

Summary: [CMake] Fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, paroga, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Reference this bug in the ChangeLog none

Raphael Kubo da Costa (:rakuco)
Reported 2012-02-29 18:24:52 PST
[CMake] Fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
Attachments
Patch (1.66 KB, patch)
2012-02-29 18:26 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Reference this bug in the ChangeLog (1.72 KB, patch)
2012-02-29 18:35 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-02-29 18:26:00 PST
Created attachment 129575 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-02-29 18:29:16 PST
I was going to commit this directly without filing a bug report, but since svn.webkit.org seems to be down again I figured it would be a good idea to create the bug to make it serve as a heads-up to everyone interested in CMake. CMake automatically passes -fPIC to the compiler when creating shared libraries, but it doesn't do that for static libs. Since WTF is now always built as a static lib, shared libraries such as JSC failed to link against it on platforms such as x86-64.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-02-29 18:35:16 PST
Created attachment 129609 [details] Reference this bug in the ChangeLog
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-02-29 18:40:01 PST
Committed r109295: <http://trac.webkit.org/changeset/109295>
Note You need to log in before you can comment on or make changes to this bug.