Bug 79955

Summary: Some trivial file stream cleanup
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, jianli, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
without unneeded changes sam: review+

Description Alexey Proskuryakov 2012-02-29 15:59:16 PST 
Not much to see here...
Comment 1 Alexey Proskuryakov 2012-02-29 16:07:35 PST 
Created attachment 129543 [details]
proposed patch
Comment 2 Jian Li 2012-02-29 16:20:43 PST 
Why do we need to include ValueCheck.h in AsyncFileStream.h?
Comment 3 Alexey Proskuryakov 2012-02-29 16:28:02 PST 
Ah yes, I ended up not using it. Please ignore the include, and JavaScriptCore changes.
Comment 4 Alexey Proskuryakov 2012-02-29 16:29:46 PST 
Created attachment 129550 [details]
without unneeded changes
Comment 5 WebKit Review Bot 2012-02-29 16:32:23 PST 
Attachment 129550 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/fileapi/FileStreamProxy.h:65:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexey Proskuryakov 2012-03-01 10:06:33 PST 
Committed <http://trac.webkit.org/changeset/109360>.