Bug 79950 – IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted

• Component: New Bugs
• Status: RESOLVED FIXED

[Joshua Bell]

IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted

[Joshua Bell]

Created attachment 129526 [details]
Patch

[Joshua Bell]

Not high priority, but easy.

[Joshua Bell]

Note that this is not in the spec yet, but there is consensus in the tracking bug for it:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=16013

[David Grogan]

LGTM idb-wise

[Tony Chang]

Comment on attachment 129526 [details]
Patch

This is fine, but arv tells me that in the long run, DOMStringList is going away.

[Joshua Bell]

(In reply to comment #5)
> (From update of attachment 129526 [details])
> This is fine, but arv tells me that in the long run, DOMStringList is going away.

Yeah, tracking that as: http://code.google.com/p/chromium/issues/detail?id=115665

[Tony Chang]

Comment on attachment 129526 [details]
Patch

Also, it's a bit inefficient that we sort each time we access the property rather than using a sorted hash map (hashset), but last I checked, this data structure doesn't exist wtf.

[WebKit Review Bot]

Comment on attachment 129526 [details]
Patch

Rejecting attachment 129526 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Joshua Bell]

Comment on attachment 129526 [details]
Patch

Must have been a glitch, trying again...

[WebKit Review Bot]

Comment on attachment 129526 [details]
Patch

Clearing flags on attachment: 129526

Committed r109305: <http://trac.webkit.org/changeset/109305>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.