Bug 7995 – is css/maketokenizer is removing the type defs

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Michael Emmel]

It seems on OSX the flex typedefs are being picked up from the system while this is not true under linux.

Patch attached

[Michael Emmel]

Created attachment 7313 [details]
Patch to add typedefs

[Darin Adler]

Comment on attachment 7313 [details]
Patch to add typedefs

I'm not sure I understand what's going on here. The tokenizer.cpp file generated by our version of flex, 2.5.4, doesn't contain any references to types with a "flex_" prefix.

It's not true that under OS X the flex types are being "picked up from the OS". What's happening is that these types don't exist at all in the version of flex we're using.

I think there are probably better ways to fix this. The maketokenizer script throws away a lot of what flex generates -- we should probably fix it to keep around the typedefs.

[Darin Adler]

Comment on attachment 7313 [details]
Patch to add typedefs

This is not the right fix -- we don't want our own copy of the flex typedefs. But I'm sure we can tweak the script another way to make it work with this newer version of flex.

It's worth looking at the latest KDE version of this script to see what they decided to do, since this is the unmodified original script we got from them.

[Eric Seidel (no email)]

This must have been worked around in some other way in the last 9 months, no?  I would think this bug could be closed by now.  Last I knew GTKWebKit even has its own buildbot:
http://build.webkit.org/post-commit-linux-gtk