| Summary: | Sync PageCache debugging with PageCache behaviour | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Peters <gavinp> | ||||||
| Component: | New Bugs | Assignee: | Gavin Peters <gavinp> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, beidson, japhet, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Gavin Peters
2012-02-29 14:10:25 PST
Created attachment 129517 [details]
Patch
This is the clean-up-the-debugging part of now-retired Bug 79269. Comment on attachment 129517 [details] Patch Rejecting attachment 129517 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: as type 'int' Source/WebCore/history/PageCache.cpp:209: error: cannot pass objects of non-POD type 'class WTF::String' through '...'; call will abort at runtime Source/WebCore/history/PageCache.cpp:209: error: format '%s' expects type 'char*', but argument 5 has type 'int' CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/inspector/DOMEditor.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/history/PageCache.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/11751954 Created attachment 129915 [details]
Patch
It seems I neglected to test my patch on Chromium. Now done, I'll wait on EWS and then cq+. Comment on attachment 129915 [details]
Patch
Forwarding beidson's r+.
Comment on attachment 129915 [details] Patch Clearing flags on attachment: 129915 Committed r109598: <http://trac.webkit.org/changeset/109598> All reviewed patches have been landed. Closing bug. |