Summary: | [chromium] Use webkit_support to create session storage namespaces in DRT. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Nordman <michaeln> | ||||
Component: | Tools / Tests | Assignee: | Michael Nordman <michaeln> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, tkent, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Nordman
2012-02-29 12:44:58 PST
Created attachment 129508 [details] drt commit needs to wait for the chromium-side change in which the new webkit_support function is defined to land, http://codereview.chromium.org/9429029/ tony, ptal Comment on attachment 129508 [details] drt View in context: https://bugs.webkit.org/attachment.cgi?id=129508&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:276 > - return WebKit::WebStorageNamespace::createSessionStorageNamespace(quota); > + return webkit_support::CreateSessionStorageNamespace(quota); I don't see this method in webkit/support/webkit_support.h. Am I missing something? Comment on attachment 129508 [details] drt Sorry, just read comment #1. You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands. (In reply to comment #4) > You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands. will do, thnx Comment on attachment 129508 [details] drt Attachment 129508 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11766134 Comment on attachment 129508 [details]
drt
putting in the commit-queue now that we've rolled DEPs to 124511 (well past 124337)
Comment on attachment 129508 [details] drt Clearing flags on attachment: 129508 Committed r109462: <http://trac.webkit.org/changeset/109462> All reviewed patches have been landed. Closing bug. |