| Summary: | Autocomplete attribute should apply to textarea's. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||||||||
| Component: | WebKit BlackBerry | Assignee: | Mike Fenton <mifenton> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Mike Fenton
2012-02-29 11:34:37 PST
Created attachment 129482 [details]
Patch
Comment on attachment 129482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129482&action=review > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:183 > + return elementAttributeState(element, QualifiedName(nullAtom, "autocorrect", nullAtom)); I would do DEFINE_STATIC_LOCAL(AtomicString, autocorrect, ("autocorrect")); > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:191 > +AttributeState elementAttributeState(const Element* element, const QualifiedName& attributeName) 'AttributeState' reads too generic for its scoped purposes, I would think. Created attachment 129489 [details]
Patch based on suggestion.
Created attachment 129501 [details]
Updated patch based on suggestion.
Comment on attachment 129482 [details] Patch Clearing flags on attachment: 129482 Committed r109284: <http://trac.webkit.org/changeset/109284> All reviewed patches have been landed. Closing bug. Created attachment 129684 [details]
Updated second patch.
Reopening to land followup patch. Comment on attachment 129501 [details] Updated patch based on suggestion. Rejecting attachment 129501 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11779449 Comment on attachment 129684 [details] Updated second patch. Rejecting attachment 129684 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11779451 Created attachment 129688 [details]
Updated patch with reviewer in Changelog.
The commit-queue encountered the following flaky tests while processing attachment 129688 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 129688 [details] Updated patch with reviewer in Changelog. Rejecting attachment 129688 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Source/WebKit/chromium/ChangeLog Failed to merge in the changes. Patch failed at 0001 Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/11769544 Comment on attachment 129688 [details] Updated patch with reviewer in Changelog. Clearing flags on attachment: 129688 Committed r109430: <http://trac.webkit.org/changeset/109430> All reviewed patches have been landed. Closing bug. |