Bug 79868

Summary:

Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

OS X 10.7

Attachments:

Description	Flags
Patch	andersca: review+

Description Beth Dakin 2012-02-28 21:51:58 PST

Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin. <rdar://problem/10688637>

Comment 1 Beth Dakin 2012-02-28 21:56:41 PST

Created attachment 129385 [details]
Patch

Comment 2 Anders Carlsson 2012-02-29 08:59:37 PST

Comment on attachment 129385 [details]
Patch

I think you should change all handleWheelEventPhase functions to just take the phase enum, that way you'll avoid copying the event object when all you want is the phase.

Looks great otherwise!

Comment 3 Anders Carlsson 2012-02-29 09:02:47 PST

Comment on attachment 129385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129385&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:89
> +    virtual void handleWheelEventPhase(const PlatformWheelEvent&);

This could be marked OVERRIDE.

Comment 4 Beth Dakin 2012-02-29 11:52:44 PST

Thanks Anders! Committed change with http://trac.webkit.org/changeset/109237