| Summary: | [BlackBerry]Make about:cache feature available in release version. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Liu <jasonliuwebkit> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | charles.wei, dbates, jasonliuwebkit, jrogers, leo.yang, staikos, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Attachments: |
|
||||||||
|
Description
Jason Liu
2012-02-28 21:42:35 PST
Created attachment 129386 [details]
Patch
Created attachment 129396 [details]
Patch
I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? (In reply to comment #3) > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. I made the second patch to replace the tab with space in the first one. (In reply to comment #4) > (In reply to comment #3) > > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? > > We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. > > I made the second patch to replace the tab with space in the first one. My mistake, I realized after that you moved it. LGTM. Comment on attachment 129396 [details]
Patch
ja
Comment on attachment 129396 [details] Patch Clearing flags on attachment: 129396 Committed r109301: <http://trac.webkit.org/changeset/109301> All reviewed patches have been landed. Closing bug. |