Bug 79866

Summary: [BlackBerry]Make about:cache feature available in release version.
Product: WebKit Reporter: Jason Liu <jasonliuwebkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, dbates, jasonliuwebkit, jrogers, leo.yang, staikos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Jason Liu
Reported 2012-02-28 21:42:35 PST
Make about:cache feature available in release version.
Attachments
Patch (1.90 KB, patch)
2012-02-28 21:59 PST, Jason Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2012-02-28 23:10 PST, Jason Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jason Liu
Comment 1 2012-02-28 21:59:02 PST
Created attachment 129386 [details] Patch
Jason Liu
Comment 2 2012-02-28 23:10:50 PST
Created attachment 129396 [details] Patch
Jeff Rogers
Comment 3 2012-02-29 15:59:47 PST
I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether?
Jason Liu
Comment 4 2012-02-29 18:23:44 PST
(In reply to comment #3) > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. I made the second patch to replace the tab with space in the first one.
Jeff Rogers
Comment 5 2012-02-29 18:35:32 PST
(In reply to comment #4) > (In reply to comment #3) > > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether? > > We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version. > > I made the second patch to replace the tab with space in the first one. My mistake, I realized after that you moved it. LGTM.
Antonio Gomes
Comment 6 2012-02-29 19:50:45 PST
Comment on attachment 129396 [details] Patch ja
WebKit Review Bot
Comment 7 2012-02-29 20:20:40 PST
Comment on attachment 129396 [details] Patch Clearing flags on attachment: 129396 Committed r109301: <http://trac.webkit.org/changeset/109301>
WebKit Review Bot
Comment 8 2012-02-29 20:20:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.