Summary: | [EFL] Build warning : comparison between signed and unsigned integer expressions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Byungwoo Lee <bw80.lee> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Byungwoo Lee
2012-02-28 19:44:34 PST
Created attachment 129400 [details]
Patch
Comment on attachment 129400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129400&action=review > Source/WebKit/efl/ewk/ewk_view_single.cpp:109 > + for (uint32_t i = 0; i < copyHeight; i++) { size_t looks better for me. (In reply to comment #2) > (From update of attachment 129400 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129400&action=review > > Source/WebKit/efl/ewk/ewk_view_single.cpp:109 > > + for (uint32_t i = 0; i < copyHeight; i++) { > size_t looks better for me. Ok~ I'll fix this and also about the below. + for (uint32_t i = 0; i < exec->argumentCount(); i++) (The return type of ExecState::argumentCount() is size_t) Thanks for the comment. Created attachment 129788 [details]
Patch
Comment on attachment 129788 [details]
Patch
LGTM too.
Comment on attachment 129788 [details] Patch Clearing flags on attachment: 129788 Committed r109544: <http://trac.webkit.org/changeset/109544> All reviewed patches have been landed. Closing bug. |