Bug 79826

Summary: [BlackBerry] Update the WebKit API to use std::string rather than char*
Product: WebKit Reporter: Konrad Piascik <kpiascik>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: efidler, joenotcharles, manyoso, mstaikos, staikos, tonikitoo, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 79818, 79829, 79830    
Bug Blocks:    

Description Konrad Piascik 2012-02-28 13:15:34 PST 
Currently there are several methods in both WebPage.h and WebPageClient.h which use char* where std::string would be better suited.  These should be updated if possible.
This will be a meta bug to track individual changes.  This is to encourage smaller patches that are both reviewable and less prone to regressions and breakage.
Comment 1 Antonio Gomes 2012-03-03 17:51:48 PST 
@all, do you have a agreement?
Comment 2 Antonio Gomes 2012-03-03 17:52:30 PST 
(In reply to comment #1)
> @all, do you have a agreement?

err!

@all: do we have an agreement?
Comment 3 Joe Mason 2012-03-05 14:17:11 PST 
No - I agree that char* should be deprecated, but I think the API should use WebString in most places. (And in NetworkJob::notifyDataReceived and similar, it should use a buffer class that's a thin wrapper around char*, since the data is not actually a string.)  std::string will need to be converted to WTF::String eventually anyway, so we might as well do it on the platform side.  This will let us avoid char*->std::string->WTF::String conversions.
Comment 4 George Staikos 2012-11-14 11:00:08 PST 
No we won't