| Summary: | More Pasteboard code cleanup | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
| Component: | HTML Editing | Assignee: | Enrica Casucci <enrica> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, ap, dglazkov, japhet, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Enrica Casucci
2012-02-28 11:35:07 PST
Created attachment 129301 [details]
Patch
Comment on attachment 129301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review > Source/WebCore/editing/mac/EditorMac.mm:286 > + types.append(String(NSStringPboardType)); Is the explicit construction necessary here? > Source/WebCore/platform/mac/PasteboardHelper.h:-43 > - class PasteboardHelper { I love to see "helper" pseudo-classes gone! Comment on attachment 129301 [details] Patch Attachment 129301 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11714031 New failing tests: css3/filters/effect-invert-hw.html (In reply to comment #2) > (From update of attachment 129301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review > > > Source/WebCore/editing/mac/EditorMac.mm:286 > > + types.append(String(NSStringPboardType)); > > Is the explicit construction necessary here? > Yes. |