Bug 79816

Summary:

More Pasteboard code cleanup

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

HTML Editing

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, dglazkov, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+, webkit.review.bot: commit-queue-

Enrica Casucci

Reported 2012-02-28 11:35:07 PST

Cleanup the last references to NSPasteboard in the DragClient.h interface.

Attachments
Patch (16.51 KB, patch) 2012-02-28 11:43 PST, Enrica Casucci	ap: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Enrica Casucci

Comment 1 2012-02-28 11:43:39 PST

Created attachment 129301 [details] Patch

Alexey Proskuryakov

Comment 2 2012-02-28 12:06:06 PST

Comment on attachment 129301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review > Source/WebCore/editing/mac/EditorMac.mm:286 > + types.append(String(NSStringPboardType)); Is the explicit construction necessary here? > Source/WebCore/platform/mac/PasteboardHelper.h:-43 > - class PasteboardHelper { I love to see "helper" pseudo-classes gone!

WebKit Review Bot

Comment 3 2012-02-28 12:22:46 PST

Comment on attachment 129301 [details] Patch Attachment 129301 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11714031 New failing tests: css3/filters/effect-invert-hw.html

Enrica Casucci

Comment 4 2012-02-28 13:53:50 PST

(In reply to comment #2) > (From update of attachment 129301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review > > > Source/WebCore/editing/mac/EditorMac.mm:286 > > + types.append(String(NSStringPboardType)); > > Is the explicit construction necessary here? > Yes.

Enrica Casucci

Comment 5 2012-02-28 13:58:47 PST

http://trac.webkit.org/changeset/109147

Note You need to log in before you can comment on or make changes to this bug.