Bug 79812

Summary: Full screen video volume slider has "progress bar"
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, macpherson, menard, tkent, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2012-02-28 11:11:46 PST
Enlarging an embedded video to full screen shows that the volume slider appears to have a "progress bar" (see attached image).
Attachments
Patch (400.58 KB, patch)
2012-02-28 11:40 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (610.87 KB, patch)
2012-02-28 13:29 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (610.89 KB, patch)
2012-02-28 13:33 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (970.74 KB, patch)
2012-02-28 13:47 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (970.71 KB, patch)
2012-02-28 16:12 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (229.19 KB, patch)
2012-02-28 16:52 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-02-28 11:12:06 PST
<rdar://problem/9432696>
Jer Noble
Comment 2 2012-02-28 11:40:10 PST
Created attachment 129300 [details] Patch
WebKit Review Bot
Comment 3 2012-02-28 11:56:50 PST
Comment on attachment 129300 [details] Patch Attachment 129300 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11709034
Jer Noble
Comment 4 2012-02-28 13:29:12 PST
Created attachment 129317 [details] Patch
Jer Noble
Comment 5 2012-02-28 13:33:06 PST
Created attachment 129319 [details] Patch Added missing break statement in CSSPrimitiveValueMappings.h
Jer Noble
Comment 6 2012-02-28 13:47:08 PST
Created attachment 129323 [details] Patch Rebaselined.
WebKit Review Bot
Comment 7 2012-02-28 14:26:07 PST
Comment on attachment 129323 [details] Patch Attachment 129323 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11711110
Jer Noble
Comment 8 2012-02-28 16:12:17 PST
Created attachment 129349 [details] Patch Fullscreen -> FullScreen in all cases.
Jer Noble
Comment 9 2012-02-28 16:52:02 PST
Created attachment 129355 [details] Patch Update WKSI to latest version (fixing mac compilation error).
Eric Carlson
Comment 10 2012-02-29 09:52:57 PST
Comment on attachment 129355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129355&action=review > Source/WebCore/rendering/RenderThemeMac.h:161 > + virtual bool paintMediaFullScreenVolumeSliderTrack(RenderObject*, const PaintInfo&, const IntRect&); > + virtual bool paintMediaFullScreenVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&); The new WebKit hottness is to mark virtual overrides with OVERRIDE. All the cool kids are doing it, you should too!
Jer Noble
Comment 11 2012-02-29 10:55:26 PST
Committed r109231: <http://trac.webkit.org/changeset/109231>
Note You need to log in before you can comment on or make changes to this bug.