Summary: | Full screen video volume slider has "progress bar" | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | dglazkov, macpherson, menard, tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | OS X 10.7 | ||||||||||||||||
Attachments: |
|
Description
Jer Noble
2012-02-28 11:11:46 PST
Created attachment 129300 [details]
Patch
Comment on attachment 129300 [details] Patch Attachment 129300 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11709034 Created attachment 129317 [details]
Patch
Created attachment 129319 [details]
Patch
Added missing break statement in CSSPrimitiveValueMappings.h
Created attachment 129323 [details]
Patch
Rebaselined.
Comment on attachment 129323 [details] Patch Attachment 129323 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11711110 Created attachment 129349 [details]
Patch
Fullscreen -> FullScreen in all cases.
Created attachment 129355 [details]
Patch
Update WKSI to latest version (fixing mac compilation error).
Comment on attachment 129355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129355&action=review > Source/WebCore/rendering/RenderThemeMac.h:161 > + virtual bool paintMediaFullScreenVolumeSliderTrack(RenderObject*, const PaintInfo&, const IntRect&); > + virtual bool paintMediaFullScreenVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&); The new WebKit hottness is to mark virtual overrides with OVERRIDE. All the cool kids are doing it, you should too! Committed r109231: <http://trac.webkit.org/changeset/109231> |