Bug 79807

Summary: Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: New BugsAssignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch haraken: review+, webkit.review.bot: commit-queue-

Pavel Podivilov
Reported 2012-02-28 09:22:36 PST
Currently 'static' and 'const' are placed before extended attributes which is a syntax error. http://www.w3.org/TR/WebIDL/#prod-InterfaceMembers
Attachments
Patch (11.26 KB, patch)
2012-02-28 09:24 PST, Pavel Podivilov 		haraken: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-02-28 09:24:04 PST
Created attachment 129278 [details] Patch
Kentaro Hara
Comment 2 2012-02-28 15:41:59 PST
Comment on attachment 129278 [details] Patch OK. Thanks for the patch!
WebKit Review Bot
Comment 3 2012-02-29 01:24:31 PST
The commit-queue encountered the following flaky tests while processing attachment 129278 [details]: fast/dom/error-to-string-stack-overflow.html bug 79894 (authors: ager@chromium.org and arv@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 4 2012-02-29 01:25:40 PST
Comment on attachment 129278 [details] Patch Rejecting attachment 129278 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Refactoring] Shadow related attach paths should be in ShadowTree. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/11746103
Pavel Podivilov
Comment 5 2012-02-29 07:24:40 PST
Committed r109210: <http://trac.webkit.org/changeset/109210>
Note You need to log in before you can comment on or make changes to this bug.