Bug 79792

Summary: Web Inspector: preserve memory counters size after frontend reopening
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Yury Semikhatsky
Reported 2012-02-28 07:38:41 PST
The size should be restored.
Attachments
Patch (4.35 KB, patch)
2012-02-28 07:40 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-02-28 07:40:41 PST
Created attachment 129253 [details] Patch
Pavel Feldman
Comment 2 2012-02-28 08:12:13 PST
Comment on attachment 129253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:66 > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600); Inspector's default height is 600, this should be 150. > Source/WebCore/inspector/front-end/TimelinePanel.js:175 > + WebInspector.settings.memoryCounterGraphsHeight.set(top); this should be a part of _endSplitterDragging.
Yury Semikhatsky
Comment 3 2012-02-28 08:22:00 PST
(In reply to comment #2) > (From update of attachment 129253 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review > > > Source/WebCore/inspector/front-end/TimelinePanel.js:66 > > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600); > > Inspector's default height is 600, this should be 150. > Done. > > Source/WebCore/inspector/front-end/TimelinePanel.js:175 > > + WebInspector.settings.memoryCounterGraphsHeight.set(top); > > this should be a part of _endSplitterDragging. Done.
Yury Semikhatsky
Comment 4 2012-02-28 08:27:56 PST
Committed r109109: <http://trac.webkit.org/changeset/109109>
Note You need to log in before you can comment on or make changes to this bug.