Summary: | Setting mode for track element not working | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Dutton <dutton> | ||||||||||||
Component: | Media | Assignee: | Anna Cavender <annacc> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | annacc, arun.patole, ericbidelman, eric.carlson, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Sam Dutton
2012-02-28 07:28:25 PST
I believe the problem is that when the mode is set, m_showingByDefault remains true, when really it should be set to false. Patch coming shortly. Created attachment 135231 [details]
fixes problem, needs tests
This change looks OK, but we should have the test in the same patch. Created attachment 135405 [details]
including tests
Comment on attachment 135405 [details] including tests View in context: https://bugs.webkit.org/attachment.cgi?id=135405&action=review > LayoutTests/media/track/track-mode.html:16 > + Nit: this blank line is unnecessary. Created attachment 135436 [details]
Patch for landing
Comment on attachment 135436 [details] Patch for landing Rejecting attachment 135436 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12317525 Created attachment 135450 [details]
Patch for landing
Comment on attachment 135450 [details] Patch for landing Clearing flags on attachment: 135450 Committed r113110: <http://trac.webkit.org/changeset/113110> All reviewed patches have been landed. Closing bug. |